Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

#134 Made number.pow object strong typed #135

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Jul 12, 2023

Closes: #134


PR-Codex overview

Focus of this PR:

Adding an ability to raise a number to a float power.

Detailed summary:

  • Renamed the pow parameter from x to number in number.eo.
  • Added a todo comment to implement raising a number to a float power.
  • Modified the EOnumber$EOpow class in EOnumber$EOpow.java:
    • Removed the import statement for EOerror.
    • Added a new PhWith object to return the result with the number parameter set to phi.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please have a look

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jul 12, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 648868c into objectionary:master Jul 12, 2023
8 checks passed
@rultor
Copy link
Contributor

rultor commented Jul 12, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 6min)

@yegor256
Copy link
Member

@rultor release, tag is 0.4.1

@rultor
Copy link
Contributor

rultor commented Jul 14, 2023

@rultor release, tag is 0.4.1

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Jul 14, 2023

@rultor release, tag is 0.4.1

@yegor256 Done! FYI, the full log is here (took me 12min)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of weak typed atoms in repository
3 participants